Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on abstract message in schema extractor #7260

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Remove dependency on abstract message in schema extractor #7260

merged 2 commits into from
Oct 16, 2024

Conversation

piochelepiotr
Copy link
Contributor

@piochelepiotr piochelepiotr commented Jun 28, 2024 •
edited
Loading

What Does This Do

Motivation

Trying to solve this error:

java.lang.IllegalAccessError: class datadog.trace.instrumentation.protobuf_java.SchemaExtractor (in unnamed module @xxxxxx) cannot access class com.google.protobuf.AbstractMessage (in module xxxx.yyyy) because module xxxx.yyyy does not export com.google.protobuf to unnamed module @xxxxxxxx

My theory is that the dynamic message instrumentation calls this class, but dynamic message has nothing to do with AbstractMessage, so maybe in some cases DynamicMessage exists, but not AbstractMessage?
But that doesn't seem to be 100% correlated with the error.

Additional Notes

I'm not confident this will work. Since the error says the whole protobuf module is not exported.
But I only instrument classes extending protobuf classes, so I don't understand how that can happen.

Jira ticket: [PROJ-IDENT]

@piochelepiotr piochelepiotr requested a review from a team as a code owner June 28, 2024 17:01
@pr-commenter
Copy link

pr-commenter bot commented Jun 28, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master piotr-wolski/data-streams-fix-crash-schema-tracking
git_commit_date 1729088733 1729095621
git_commit_sha 3f89f03 abae22e
release_version 1.41.0-SNAPSHOT~3f89f0321b 1.41.0-SNAPSHOT~abae22ea8e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729098170 1729098170
ci_job_id 674347560 674347560
ci_pipeline_id 46739093 46739093
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.41.0-SNAPSHOT~abae22ea8e, baseline=1.41.0-SNAPSHOT~3f89f0321b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081380
Total [baseline] (8.614 s) : 0, 8614081
Agent [candidate] (1.072 s) : 0, 1072455
Total [candidate] (8.575 s) : 0, 8574765
section iast
Agent [baseline] (1.217 s) : 0, 1217125
Total [baseline] (9.106 s) : 0, 9106040
Agent [candidate] (1.2 s) : 0, 1200001
Total [candidate] (9.107 s) : 0, 9107161
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1199246
Total [baseline] (9.088 s) : 0, 9088376
Agent [candidate] (1.2 s) : 0, 1199793
Total [candidate] (9.084 s) : 0, 9084083
section iast_TELEMETRY_OFF
Agent [baseline] (1.198 s) : 0, 1197599
Total [baseline] (9.093 s) : 0, 9093309
Agent [candidate] (1.207 s) : 0, 1206580
Total [candidate] (9.111 s) : 0, 9110679
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.217 s 135.745 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 117.866 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.198 s 116.219 ms (10.7%)
Total tracing 8.614 s -
Total iast 9.106 s 491.959 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.088 s 474.295 ms (5.5%)
Total iast_TELEMETRY_OFF 9.093 s 479.228 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent iast 1.2 s 127.546 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.2 s 127.337 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.207 s 134.125 ms (12.5%)
Total tracing 8.575 s -
Total iast 9.107 s 532.396 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.084 s 509.318 ms (5.9%)
Total iast_TELEMETRY_OFF 9.111 s 535.913 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.41.0-SNAPSHOT~abae22ea8e, baseline=1.41.0-SNAPSHOT~3f89f0321b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (689.761 ms) : 0, 689761
BytebuddyAgent [candidate] (683.574 ms) : 0, 683574
GlobalTracer [baseline] (314.939 ms) : 0, 314939
GlobalTracer [candidate] (312.964 ms) : 0, 312964
AppSec [baseline] (54.616 ms) : 0, 54616
AppSec [candidate] (54.009 ms) : 0, 54009
Remote Config [baseline] (672.388 µs) : 0, 672
Remote Config [candidate] (668.979 µs) : 0, 669
Telemetry [baseline] (7.592 ms) : 0, 7592
Telemetry [candidate] (7.539 ms) : 0, 7539
section iast
BytebuddyAgent [baseline] (811.019 ms) : 0, 811019
BytebuddyAgent [candidate] (797.903 ms) : 0, 797903
GlobalTracer [baseline] (305.377 ms) : 0, 305377
GlobalTracer [candidate] (301.95 ms) : 0, 301950
AppSec [baseline] (56.954 ms) : 0, 56954
AppSec [candidate] (57.487 ms) : 0, 57487
IAST [baseline] (22.128 ms) : 0, 22128
IAST [candidate] (21.234 ms) : 0, 21234
Remote Config [baseline] (597.882 µs) : 0, 598
Remote Config [candidate] (593.385 µs) : 0, 593
Telemetry [baseline] (7.109 ms) : 0, 7109
Telemetry [candidate] (7.076 ms) : 0, 7076
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.345 ms) : 0, 797345
BytebuddyAgent [candidate] (797.515 ms) : 0, 797515
GlobalTracer [baseline] (301.79 ms) : 0, 301790
GlobalTracer [candidate] (302.021 ms) : 0, 302021
AppSec [baseline] (55.994 ms) : 0, 55994
AppSec [candidate] (56.8 ms) : 0, 56800
IAST [baseline] (22.722 ms) : 0, 22722
IAST [candidate] (22.066 ms) : 0, 22066
Remote Config [baseline] (597.667 µs) : 0, 598
Remote Config [candidate] (596.014 µs) : 0, 596
Telemetry [baseline] (7.058 ms) : 0, 7058
Telemetry [candidate] (7.02 ms) : 0, 7020
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (795.816 ms) : 0, 795816
BytebuddyAgent [candidate] (801.911 ms) : 0, 801911
GlobalTracer [baseline] (302.112 ms) : 0, 302112
GlobalTracer [candidate] (304.454 ms) : 0, 304454
AppSec [baseline] (54.284 ms) : 0, 54284
AppSec [candidate] (55.313 ms) : 0, 55313
IAST [baseline] (24.083 ms) : 0, 24083
IAST [candidate] (23.334 ms) : 0, 23334
Remote Config [baseline] (597.641 µs) : 0, 598
Remote Config [candidate] (602.956 µs) : 0, 603
Telemetry [baseline] (6.974 ms) : 0, 6974
Telemetry [candidate] (7.078 ms) : 0, 7078
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.41.0-SNAPSHOT~abae22ea8e, baseline=1.41.0-SNAPSHOT~3f89f0321b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.072 s) : 0, 1071996
Total [baseline] (10.446 s) : 0, 10446031
Agent [candidate] (1.071 s) : 0, 1071344
Total [candidate] (10.414 s) : 0, 10413938
section appsec
Agent [baseline] (1.214 s) : 0, 1213984
Total [baseline] (10.685 s) : 0, 10684811
Agent [candidate] (1.213 s) : 0, 1213482
Total [candidate] (10.666 s) : 0, 10666490
section iast
Agent [baseline] (1.214 s) : 0, 1214441
Total [baseline] (10.877 s) : 0, 10877381
Agent [candidate] (1.209 s) : 0, 1208555
Total [candidate] (10.916 s) : 0, 10916052
section profiling
Agent [baseline] (1.271 s) : 0, 1270523
Total [baseline] (10.706 s) : 0, 10705574
Agent [candidate] (1.279 s) : 0, 1278773
Total [candidate] (10.681 s) : 0, 10681427
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.214 s 141.988 ms (13.2%)
Agent iast 1.214 s 142.445 ms (13.3%)
Agent profiling 1.271 s 198.527 ms (18.5%)
Total tracing 10.446 s -
Total appsec 10.685 s 238.781 ms (2.3%)
Total iast 10.877 s 431.35 ms (4.1%)
Total profiling 10.706 s 259.543 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.213 s 142.138 ms (13.3%)
Agent iast 1.209 s 137.212 ms (12.8%)
Agent profiling 1.279 s 207.43 ms (19.4%)
Total tracing 10.414 s -
Total appsec 10.666 s 252.553 ms (2.4%)
Total iast 10.916 s 502.114 ms (4.8%)
Total profiling 10.681 s 267.489 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.41.0-SNAPSHOT~abae22ea8e, baseline=1.41.0-SNAPSHOT~3f89f0321b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.148 ms) : 0, 683148
BytebuddyAgent [candidate] (682.582 ms) : 0, 682582
GlobalTracer [baseline] (312.987 ms) : 0, 312987
GlobalTracer [candidate] (312.908 ms) : 0, 312908
AppSec [baseline] (54.013 ms) : 0, 54013
AppSec [candidate] (53.98 ms) : 0, 53980
Remote Config [baseline] (671.328 µs) : 0, 671
Remote Config [candidate] (659.979 µs) : 0, 660
Telemetry [baseline] (7.496 ms) : 0, 7496
Telemetry [candidate] (7.512 ms) : 0, 7512
section appsec
BytebuddyAgent [baseline] (705.14 ms) : 0, 705140
BytebuddyAgent [candidate] (705.162 ms) : 0, 705162
GlobalTracer [baseline] (311.368 ms) : 0, 311368
GlobalTracer [candidate] (312.584 ms) : 0, 312584
AppSec [baseline] (163.329 ms) : 0, 163329
AppSec [candidate] (163.268 ms) : 0, 163268
IAST [baseline] (20.464 ms) : 0, 20464
IAST [candidate] (19.6 ms) : 0, 19600
Remote Config [baseline] (637.287 µs) : 0, 637
Remote Config [candidate] (643.843 µs) : 0, 644
Telemetry [baseline] (9.484 ms) : 0, 9484
Telemetry [candidate] (8.217 ms) : 0, 8217
section iast
BytebuddyAgent [baseline] (808.34 ms) : 0, 808340
BytebuddyAgent [candidate] (804.561 ms) : 0, 804561
GlobalTracer [baseline] (304.78 ms) : 0, 304780
GlobalTracer [candidate] (303.886 ms) : 0, 303886
AppSec [baseline] (56.583 ms) : 0, 56583
AppSec [candidate] (57.226 ms) : 0, 57226
IAST [baseline] (23.184 ms) : 0, 23184
IAST [candidate] (21.428 ms) : 0, 21428
Remote Config [baseline] (600.078 µs) : 0, 600
Remote Config [candidate] (613.606 µs) : 0, 614
Telemetry [baseline] (7.102 ms) : 0, 7102
Telemetry [candidate] (7.058 ms) : 0, 7058
section profiling
BytebuddyAgent [baseline] (677.151 ms) : 0, 677151
BytebuddyAgent [candidate] (681.756 ms) : 0, 681756
GlobalTracer [baseline] (395.955 ms) : 0, 395955
GlobalTracer [candidate] (398.617 ms) : 0, 398617
AppSec [baseline] (54.57 ms) : 0, 54570
AppSec [candidate] (54.822 ms) : 0, 54822
Remote Config [baseline] (651.015 µs) : 0, 651
Remote Config [candidate] (647.048 µs) : 0, 647
Telemetry [baseline] (7.513 ms) : 0, 7513
Telemetry [candidate] (7.447 ms) : 0, 7447
ProfilingAgent [baseline] (95.903 ms) : 0, 95903
ProfilingAgent [candidate] (96.434 ms) : 0, 96434
Profiling [baseline] (95.926 ms) : 0, 95926
Profiling [candidate] (96.458 ms) : 0, 96458
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-10-16T16:33:16 2024-10-16T16:40:07
git_branch master piotr-wolski/data-streams-fix-crash-schema-tracking
git_commit_date 1729088733 1729095621
git_commit_sha 3f89f03 abae22e
release_version 1.41.0-SNAPSHOT~3f89f0321b 1.41.0-SNAPSHOT~abae22ea8e
start_time 2024-10-16T16:33:03 2024-10-16T16:39:54
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1729097152 1729097152
ci_job_id 674347561 674347561
ci_pipeline_id 46739093 46739093
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~abae22ea8e, baseline=1.41.0-SNAPSHOT~3f89f0321b
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.289 µs) : 347, 386
.   : milestone, 366,
iast (482.49 µs) : 462, 503
.   : milestone, 482,
iast_FULL (552.67 µs) : 531, 574
.   : milestone, 553,
iast_GLOBAL (513.534 µs) : 492, 535
.   : milestone, 514,
iast_HARDCODED_SECRET_DISABLED (486.082 µs) : 464, 508
.   : milestone, 486,
iast_INACTIVE (450.815 µs) : 429, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (472.341 µs) : 451, 494
.   : milestone, 472,
tracing (441.756 µs) : 421, 463
.   : milestone, 442,
section candidate
no_agent (372.643 µs) : 353, 392
.   : milestone, 373,
iast (481.824 µs) : 461, 503
.   : milestone, 482,
iast_FULL (549.454 µs) : 529, 570
.   : milestone, 549,
iast_GLOBAL (503.158 µs) : 482, 524
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (482.573 µs) : 461, 504
.   : milestone, 483,
iast_INACTIVE (449.686 µs) : 428, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (468.549 µs) : 448, 489
.   : milestone, 469,
tracing (452.397 µs) : 431, 474
.   : milestone, 452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.289 µs [347.069 µs, 385.509 µs] -
iast 482.49 µs [461.528 µs, 503.452 µs] 116.202 µs (31.7%)
iast_FULL 552.67 µs [531.468 µs, 573.872 µs] 186.381 µs (50.9%)
iast_GLOBAL 513.534 µs [492.061 µs, 535.007 µs] 147.245 µs (40.2%)
iast_HARDCODED_SECRET_DISABLED 486.082 µs [464.499 µs, 507.664 µs] 119.793 µs (32.7%)
iast_INACTIVE 450.815 µs [429.387 µs, 472.243 µs] 84.527 µs (23.1%)
iast_TELEMETRY_OFF 472.341 µs [450.978 µs, 493.704 µs] 106.052 µs (29.0%)
tracing 441.756 µs [420.883 µs, 462.629 µs] 75.467 µs (20.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.643 µs [353.009 µs, 392.278 µs] -
iast 481.824 µs [460.623 µs, 503.026 µs] 109.181 µs (29.3%)
iast_FULL 549.454 µs [528.503 µs, 570.405 µs] 176.811 µs (47.4%)
iast_GLOBAL 503.158 µs [482.087 µs, 524.229 µs] 130.515 µs (35.0%)
iast_HARDCODED_SECRET_DISABLED 482.573 µs [461.36 µs, 503.786 µs] 109.93 µs (29.5%)
iast_INACTIVE 449.686 µs [428.384 µs, 470.987 µs] 77.042 µs (20.7%)
iast_TELEMETRY_OFF 468.549 µs [447.62 µs, 489.477 µs] 95.905 µs (25.7%)
tracing 452.397 µs [430.713 µs, 474.082 µs] 79.754 µs (21.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.41.0-SNAPSHOT~abae22ea8e, baseline=1.41.0-SNAPSHOT~3f89f0321b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1360
.   : milestone, 1341,
appsec (1.711 ms) : 1688, 1734
.   : milestone, 1711,
appsec_no_iast (1.733 ms) : 1709, 1757
.   : milestone, 1733,
iast (1.5 ms) : 1478, 1523
.   : milestone, 1500,
profiling (1.491 ms) : 1467, 1515
.   : milestone, 1491,
tracing (1.482 ms) : 1457, 1506
.   : milestone, 1482,
section candidate
no_agent (1.317 ms) : 1297, 1336
.   : milestone, 1317,
appsec (1.713 ms) : 1690, 1735
.   : milestone, 1713,
appsec_no_iast (1.732 ms) : 1709, 1756
.   : milestone, 1732,
iast (1.466 ms) : 1443, 1489
.   : milestone, 1466,
profiling (1.483 ms) : 1460, 1506
.   : milestone, 1483,
tracing (1.457 ms) : 1433, 1481
.   : milestone, 1457,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.36 ms] -
appsec 1.711 ms [1.688 ms, 1.734 ms] 370.135 µs (27.6%)
appsec_no_iast 1.733 ms [1.709 ms, 1.757 ms] 391.755 µs (29.2%)
iast 1.5 ms [1.478 ms, 1.523 ms] 159.516 µs (11.9%)
profiling 1.491 ms [1.467 ms, 1.515 ms] 150.176 µs (11.2%)
tracing 1.482 ms [1.457 ms, 1.506 ms] 140.641 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.317 ms [1.297 ms, 1.336 ms] -
appsec 1.713 ms [1.69 ms, 1.735 ms] 396.138 µs (30.1%)
appsec_no_iast 1.732 ms [1.709 ms, 1.756 ms] 415.338 µs (31.5%)
iast 1.466 ms [1.443 ms, 1.489 ms] 149.006 µs (11.3%)
profiling 1.483 ms [1.46 ms, 1.506 ms] 166.287 µs (12.6%)
tracing 1.457 ms [1.433 ms, 1.481 ms] 139.965 µs (10.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master piotr-wolski/data-streams-fix-crash-schema-tracking
git_commit_date 1729088733 1729095621
git_commit_sha 3f89f03 abae22e
release_version 1.41.0-SNAPSHOT~3f89f0321b 1.41.0-SNAPSHOT~abae22ea8e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1729097719 1729097719
ci_job_id 674347563 674347563
ci_pipeline_id 46739093 46739093
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~abae22ea8e, baseline=1.41.0-SNAPSHOT~3f89f0321b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.333 s) : 15333000, 15333000
.   : milestone, 15333000,
appsec (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,
iast (18.928 s) : 18928000, 18928000
.   : milestone, 18928000,
iast_GLOBAL (17.832 s) : 17832000, 17832000
.   : milestone, 17832000,
profiling (15.796 s) : 15796000, 15796000
.   : milestone, 15796000,
tracing (15.285 s) : 15285000, 15285000
.   : milestone, 15285000,
section candidate
no_agent (15.028 s) : 15028000, 15028000
.   : milestone, 15028000,
appsec (14.98 s) : 14980000, 14980000
.   : milestone, 14980000,
iast (18.984 s) : 18984000, 18984000
.   : milestone, 18984000,
iast_GLOBAL (17.892 s) : 17892000, 17892000
.   : milestone, 17892000,
profiling (15.319 s) : 15319000, 15319000
.   : milestone, 15319000,
tracing (15.302 s) : 15302000, 15302000
.   : milestone, 15302000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.333 s [15.333 s, 15.333 s] -
appsec 15.071 s [15.071 s, 15.071 s] -262.0 ms (-1.7%)
iast 18.928 s [18.928 s, 18.928 s] 3.595 s (23.4%)
iast_GLOBAL 17.832 s [17.832 s, 17.832 s] 2.499 s (16.3%)
profiling 15.796 s [15.796 s, 15.796 s] 463.0 ms (3.0%)
tracing 15.285 s [15.285 s, 15.285 s] -48.0 ms (-0.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.028 s [15.028 s, 15.028 s] -
appsec 14.98 s [14.98 s, 14.98 s] -48.0 ms (-0.3%)
iast 18.984 s [18.984 s, 18.984 s] 3.956 s (26.3%)
iast_GLOBAL 17.892 s [17.892 s, 17.892 s] 2.864 s (19.1%)
profiling 15.319 s [15.319 s, 15.319 s] 291.0 ms (1.9%)
tracing 15.302 s [15.302 s, 15.302 s] 274.0 ms (1.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.41.0-SNAPSHOT~abae22ea8e, baseline=1.41.0-SNAPSHOT~3f89f0321b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.316 ms) : 2275, 2357
.   : milestone, 2316,
iast (2.055 ms) : 2003, 2106
.   : milestone, 2055,
iast_GLOBAL (2.111 ms) : 2058, 2163
.   : milestone, 2111,
profiling (1.919 ms) : 1877, 1961
.   : milestone, 1919,
tracing (1.932 ms) : 1891, 1973
.   : milestone, 1932,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.313 ms) : 2272, 2354
.   : milestone, 2313,
iast (2.056 ms) : 2005, 2108
.   : milestone, 2056,
iast_GLOBAL (2.1 ms) : 2048, 2152
.   : milestone, 2100,
profiling (1.94 ms) : 1897, 1983
.   : milestone, 1940,
tracing (1.912 ms) : 1873, 1952
.   : milestone, 1912,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.316 ms [2.275 ms, 2.357 ms] 848.77 µs (57.8%)
iast 2.055 ms [2.003 ms, 2.106 ms] 587.278 µs (40.0%)
iast_GLOBAL 2.111 ms [2.058 ms, 2.163 ms] 643.296 µs (43.8%)
profiling 1.919 ms [1.877 ms, 1.961 ms] 451.938 µs (30.8%)
tracing 1.932 ms [1.891 ms, 1.973 ms] 464.167 µs (31.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.458 ms, 1.481 ms] -
appsec 2.313 ms [2.272 ms, 2.354 ms] 843.283 µs (57.4%)
iast 2.056 ms [2.005 ms, 2.108 ms] 586.525 µs (39.9%)
iast_GLOBAL 2.1 ms [2.048 ms, 2.152 ms] 630.412 µs (42.9%)
profiling 1.94 ms [1.897 ms, 1.983 ms] 470.406 µs (32.0%)
tracing 1.912 ms [1.873 ms, 1.952 ms] 442.523 µs (30.1%)

@piochelepiotr piochelepiotr force-pushed the piotr-wolski/data-streams-fix-crash-schema-tracking branch 2 times, most recently from 2c875e0 to ec9f8d0 Compare October 9, 2024 14:25
@piochelepiotr piochelepiotr requested a review from a team as a code owner October 9, 2024 14:25
@piochelepiotr piochelepiotr force-pushed the piotr-wolski/data-streams-fix-crash-schema-tracking branch 2 times, most recently from 2e63cbe to 218ec32 Compare October 10, 2024 16:05
@piochelepiotr piochelepiotr force-pushed the piotr-wolski/data-streams-fix-crash-schema-tracking branch from 218ec32 to 336da63 Compare October 10, 2024 21:00
@pr-commenter
Copy link

pr-commenter bot commented Oct 11, 2024

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master piotr-wolski/data-streams-fix-crash-schema-tracking
git_commit_date 1728579809 1728593590
git_commit_sha 4ac37fc 336da63
See matching parameters
Baseline Candidate
ci_job_date 1728662327 1728662327
ci_job_id 669161802 669161802
ci_pipeline_id 46340568 46340568
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Oct 11, 2024

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master piotr-wolski/data-streams-fix-crash-schema-tracking
git_commit_date 1728579809 1728593590
git_commit_sha 4ac37fc 336da63
See matching parameters
Baseline Candidate
ci_job_date 1728662367 1728662367
ci_job_id 669161803 669161803
ci_pipeline_id 46340568 46340568
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.21 11.0.21
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.21+9-post-Ubuntu-0ubuntu122.04 11.0.21+9-post-Ubuntu-0ubuntu122.04

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario Δ mean throughput
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume worse
[-8381.929op/s; -2381.825op/s] or [-4.640%; -1.318%]
See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume unsure
[-14423.130op/s; -3004.928op/s] or [-4.711%; -0.981%]
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

manuel-alvarez-alvarez
manuel-alvarez-alvarez approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piochelepiotr piochelepiotr enabled auto-merge (squash) October 16, 2024 17:14
@piochelepiotr piochelepiotr force-pushed the piotr-wolski/data-streams-fix-crash-schema-tracking branch from abae22e to 0f0d718 Compare October 16, 2024 19:45
@piochelepiotr piochelepiotr merged commit a80d13e into master Oct 16, 2024
97 of 102 checks passed
@piochelepiotr piochelepiotr deleted the piotr-wolski/data-streams-fix-crash-schema-tracking branch October 16, 2024 20:11
@github-actions github-actions bot added this to the 1.41.0 milestone Oct 16, 2024
@nayeem-kamal nayeem-kamal changed the title remove dependency on abstract message in schema extractor Remove dependency on abstract message in schema extractor Oct 17, 2024
@nayeem-kamal nayeem-kamal added type: bug inst: protobuf Protocol Buffer instrumentation labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandonr vandonr vandonr approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

Assignees
No one assigned
Labels
inst: protobuf Protocol Buffer instrumentation type: bug
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.
4 participants
@piochelepiotr @vandonr @manuel-alvarez-alvarez @nayeem-kamal